Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized measurement types for lengths and weights #6

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Generalized measurement types for lengths and weights #6

merged 2 commits into from
Dec 21, 2023

Conversation

havan
Copy link
Member

@havan havan commented Dec 21, 2023

This PR adds general length and weight measurement types.

@havan havan requested a review from SamJaarsma as a code owner December 21, 2023 12:48
SamJaarsma
SamJaarsma approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havan havan merged commit 86c93bd into dev Dec 21, 2023
6 checks passed
@havan havan deleted the ekrem/measurement-types branch December 21, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamJaarsma SamJaarsma SamJaarsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havan @SamJaarsma